Skip to content

Add live-gated default option overlay configs#154

Merged
Pigbibi merged 2 commits into
mainfrom
codex/default-option-overlay-live-gate
Jun 22, 2026
Merged

Add live-gated default option overlay configs#154
Pigbibi merged 2 commits into
mainfrom
codex/default-option-overlay-live-gate

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add centralized option overlay defaults for live US equity profiles
  • gate option order intents behind recipe promotion evidence
  • document default-on/research-only behavior and add focused tests

Tests

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src:src /usr/bin/python3 -m unittest tests.test_option_overlay tests.test_catalog -v
  • git diff --check

Note: tests.test_entrypoints was not run locally because this VPS Python environment does not have pandas installed; CI installs project dependencies.

@Pigbibi Pigbibi merged commit f7bca68 into main Jun 22, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/default-option-overlay-live-gate branch June 22, 2026 21:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c28aa305e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_entrypoints.py Outdated
self.assertEqual(decision.diagnostics["option_growth_overlay_start_usd"], 250000.0)
self.assertIs(decision.diagnostics["option_growth_overlay_active"], False)
self.assertEqual(decision.diagnostics["option_growth_overlay_skip_reason"], "below_start_usd")
self.assertNotIn("option_growth_overlay_enabled", decision.diagnostics)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update stale option-overlay entrypoint assertions

With this commit the entrypoint manifests now include **option_overlay_default_config(...), and evaluate_tqqq_growth_income passes that non-empty config into build_option_overlay_diagnostics, which emits option_growth_overlay_enabled and related research-gate fields even though it does not create order intents. In a full dependency environment this assertion is therefore false for the default TQQQ entrypoint path; the same stale expectation appears in the nearby default-config and SOXL entrypoint checks, so CI will fail until these tests assert the live-gated diagnostics instead of absence.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant